Add inputs_embeds functionality when generating with GPT-Neox #22916
Merged
gante merged 2 commits intohuggingface:mainfrom Apr 21, 2023
Merged
Add inputs_embeds functionality when generating with GPT-Neox #22916gante merged 2 commits intohuggingface:mainfrom
gante merged 2 commits intohuggingface:mainfrom
Conversation
|
The documentation is not available anymore as the PR was closed or merged. |
gante
approved these changes
Apr 21, 2023
Contributor
gante
left a comment
gante
left a comment
There was a problem hiding this comment.
Thank you for adding it! 💛
amyeroberts
approved these changes
Apr 21, 2023
Contributor
amyeroberts
left a comment
amyeroberts
left a comment
There was a problem hiding this comment.
LGTM - thanks for adding!
+1 to @gante's suggestion adding a clarifying comment
great thx for the suggestion! Co-authored-by: Joao Gante <joaofranciscocardosogante@gmail.com>
novice03
pushed a commit
to novice03/transformers
that referenced
this pull request
Jun 23, 2023
…gface#22916) * support gpt neox generate with inputs embeds * Update src/transformers/models/gpt_neox/modeling_gpt_neox.py great thx for the suggestion! Co-authored-by: Joao Gante <joaofranciscocardosogante@gmail.com> --------- Co-authored-by: Lei Li <tobiaslee@qq.com> Co-authored-by: Joao Gante <joaofranciscocardosogante@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR extends #21405 and #21889 by @gante to GPTNeox models (which also includes the recent Pythia Suite models), , making it accept inputs_embeds when generating.
Who can Review?
@gante @sgugger